Skip to content

Plan: Simple editor conversion to FactTextFieldSlider#13710

Merged
DonLakeFlyer merged 4 commits intomasterfrom
PlanSimpleEditor
Dec 7, 2025
Merged

Plan: Simple editor conversion to FactTextFieldSlider#13710
DonLakeFlyer merged 4 commits intomasterfrom
PlanSimpleEditor

Conversation

@DonLakeFlyer
Copy link
Copy Markdown
Collaborator

  • Finish converting simple item (waypoints, ...) editor to FactTextFieldSlider usage
  • Add enable check box support to FactTextFieldSlider
  • Update metadata adding values for userMin/Max

Screenshot 2025-12-07 at 1 16 46 PM

Copilot AI review requested due to automatic review settings December 7, 2025 21:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Simple Item Editor to use the FactTextFieldSlider component throughout, replacing the previous GridLayout with individual FactTextField controls. The PR adds enable/disable checkbox support to FactTextFieldSlider to handle optional parameters (nanFacts) and optional flight speed settings.

Key Changes:

  • Replaces GridLayout with individual Repeaters and FactTextFieldSlider components for a more consistent and maintainable UI structure
  • Adds optional checkbox functionality to FactTextFieldSlider for enabling/disabling parameter fields
  • Enriches metadata with userMin/userMax ranges to enable slider controls for various mission parameters

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/QmlControls/SimpleItemEditor.qml Refactors from GridLayout to individual Repeaters using FactTextFieldSlider, adds visual separators, implements checkbox pattern for nanFacts and speedSection
src/FactSystem/FactControls/FactTextFieldSlider.qml Adds showEnableCheckbox property, enableCheckBoxChecked alias, and enableCheckboxClicked signal; wraps LabelledFactTextField in RowLayout with optional checkbox
src/QmlControls/QGCSlider.qml Adds QGCPalette instance for proper color theming support
src/MissionManager/SpeedSection.FactMetaData.json Adds userMin (0) and userMax (30) for FlightSpeed to enable slider functionality
src/MissionManager/MavCmdInfoCommon.json Adds userMin/userMax metadata for multiple MAVLink command parameters, fixes decimalPlaces for yaw parameters, adds param7 definition for MAV_CMD_CONDITION_CHANGE_ALT

@DonLakeFlyer DonLakeFlyer merged commit c5d376c into master Dec 7, 2025
27 checks passed
@DonLakeFlyer DonLakeFlyer deleted the PlanSimpleEditor branch December 7, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants