Plan: Simple editor conversion to FactTextFieldSlider#13710
Merged
DonLakeFlyer merged 4 commits intomasterfrom Dec 7, 2025
Merged
Plan: Simple editor conversion to FactTextFieldSlider#13710DonLakeFlyer merged 4 commits intomasterfrom
DonLakeFlyer merged 4 commits intomasterfrom
Conversation
Collaborator
DonLakeFlyer
commented
Dec 7, 2025
- Finish converting simple item (waypoints, ...) editor to FactTextFieldSlider usage
- Add enable check box support to FactTextFieldSlider
- Update metadata adding values for userMin/Max

Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Simple Item Editor to use the FactTextFieldSlider component throughout, replacing the previous GridLayout with individual FactTextField controls. The PR adds enable/disable checkbox support to FactTextFieldSlider to handle optional parameters (nanFacts) and optional flight speed settings.
Key Changes:
- Replaces GridLayout with individual Repeaters and FactTextFieldSlider components for a more consistent and maintainable UI structure
- Adds optional checkbox functionality to FactTextFieldSlider for enabling/disabling parameter fields
- Enriches metadata with userMin/userMax ranges to enable slider controls for various mission parameters
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/QmlControls/SimpleItemEditor.qml | Refactors from GridLayout to individual Repeaters using FactTextFieldSlider, adds visual separators, implements checkbox pattern for nanFacts and speedSection |
| src/FactSystem/FactControls/FactTextFieldSlider.qml | Adds showEnableCheckbox property, enableCheckBoxChecked alias, and enableCheckboxClicked signal; wraps LabelledFactTextField in RowLayout with optional checkbox |
| src/QmlControls/QGCSlider.qml | Adds QGCPalette instance for proper color theming support |
| src/MissionManager/SpeedSection.FactMetaData.json | Adds userMin (0) and userMax (30) for FlightSpeed to enable slider functionality |
| src/MissionManager/MavCmdInfoCommon.json | Adds userMin/userMax metadata for multiple MAVLink command parameters, fixes decimalPlaces for yaw parameters, adds param7 definition for MAV_CMD_CONDITION_CHANGE_ALT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.