Merged
Conversation
And fix build related build issues. Extensions can safely just be set as 0.
This is because the MAVLink spec is now in command and we can use it.
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/flight-mode-unknown-1-655360-and-unknown-129-655360/43399/15 |
Contributor
Author
|
@farhangnaderi any idea why macOS CI is failing here? |
julianoes
force-pushed
the
pr-4.4-standard-modes
branch
2 times, most recently
from
f6ca854 to
4b6050f
Compare
julianoes
force-pushed
the
pr-4.4-standard-modes
branch
from
4b6050f to
a611c4e
Compare
Contributor
I did not have any idea about it. But seems fixed. Sorry I was at Xponential and missed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already working in the Daily Build, so - I think - it makes sense to enable this for v4.4.5.