Global position: handle ECEF conversion failures#2150
Merged
vooon merged 1 commit intomavlink:ros2from Mar 14, 2026
Merged
Conversation
…nly update map_origin, ecef_origin is conversion ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global_positioncontinues after ECEF conversion failures and either uses an uninitializedmap_pointor marks the map origin initialized with invalid/stale origin data, leading to bad local odometry/TF output.Solution: stop publishing derived local odometry/TF when fix-to-ECEF conversion fails, and make home-origin updates only after a successful conversion.