Skip to content

[next] [1] Fix Windows CI build by setting MSVC as default Rust host#590

Merged
joaoantoniocardoso merged 1 commit intomavlink:masterfrom
joaoantoniocardoso:pr/ci-cd-modernization
Mar 28, 2026
Merged

[next] [1] Fix Windows CI build by setting MSVC as default Rust host#590
joaoantoniocardoso merged 1 commit intomavlink:masterfrom
joaoantoniocardoso:pr/ci-cd-modernization

Conversation

@joaoantoniocardoso
Copy link
Copy Markdown
Collaborator

@joaoantoniocardoso joaoantoniocardoso commented Mar 26, 2026

Summary

Fix Windows CI build failure caused by Rust toolchain host/target triple mismatch on current windows-2022 runner images.

Root cause

rustup on windows-2022 now defaults to host triple x86_64-pc-windows-gnu. When deploy.yml builds with --target x86_64-pc-windows-msvc, pkg-config interprets this as cross-compilation and refuses to find glib, breaking glib-sys and all GStreamer dependencies.

Fix

Force rustup default stable-x86_64-pc-windows-msvc before the build so host and target match.

Files changed

  • .github/workflows/deploy.yml

Test plan

  • Verify Windows CI build passes
  • Verify Linux/macOS builds are unaffected

…ult Rust host

On current windows-2022 runner images, rustup installs with host triple
x86_64-pc-windows-gnu by default. When cargo then builds with --target
x86_64-pc-windows-msvc, pkg-config sees host != target and rejects it
as cross-compilation, breaking glib-sys and all GStreamer dependencies.

Force the default toolchain to stable-x86_64-pc-windows-msvc so host
and target match.
@joaoantoniocardoso joaoantoniocardoso marked this pull request as ready for review March 26, 2026 14:15
@joaoantoniocardoso joaoantoniocardoso changed the title [next] Modernize CI with nextest and fix Windows MSVC build [next] [1] Modernize CI with nextest and fix Windows MSVC build Mar 26, 2026
@joaoantoniocardoso joaoantoniocardoso changed the title [next] [1] Modernize CI with nextest and fix Windows MSVC build [next] Fix Windows CI build by setting MSVC as default Rust host Mar 26, 2026
@joaoantoniocardoso joaoantoniocardoso changed the title [next] Fix Windows CI build by setting MSVC as default Rust host [next] [1] Fix Windows CI build by setting MSVC as default Rust host Mar 26, 2026
@joaoantoniocardoso joaoantoniocardoso merged commit aa0e9ba into mavlink:master Mar 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants