Telemetry and TelemetryServer improvements#364
Merged
julianoes merged 4 commits intomavlink:mainfrom Feb 12, 2025
Merged
Conversation
protos/telemetry/telemetry.proto
Outdated
| float climb_rate_m_s = 3 [(mavsdk.options.default_value)="NaN"]; // Current climb rate in metres per second | ||
| float groundspeed_m_s = 4 [(mavsdk.options.default_value)="NaN"]; // Current groundspeed metres per second | ||
| float heading_deg = 5 [(mavsdk.options.default_value)="NaN"]; // Current heading in compass units (0-360, 0=north) | ||
| float altitude_msl = 6 [(mavsdk.options.default_value)="NaN"]; // Current altitude in metres (MSL) |
Collaborator
There was a problem hiding this comment.
Maybe this would be more consistent with the others?
Suggested change
| float altitude_msl = 6 [(mavsdk.options.default_value)="NaN"]; // Current altitude in metres (MSL) | |
| float absolute_altitude_m = 6 [(mavsdk.options.default_value)="NaN"]; // Current altitude in metres (MSL) |
Contributor
Author
There was a problem hiding this comment.
Yep no problem, will do
- absolute_altitude_m
Contributor
Author
There was a problem hiding this comment.
Done. Sorry had to test on two different branches, which is why I didn't commit directly. Should be there though.
| float climb_rate_m_s = 3 [(mavsdk.options.default_value)="NaN"]; // Current climb rate in metres per second | ||
| float groundspeed_m_s = 4 [(mavsdk.options.default_value)="NaN"]; // Current groundspeed metres per second | ||
| float heading_deg = 5 [(mavsdk.options.default_value)="NaN"]; // Current heading in compass units (0-360, 0=north) | ||
| float altitude_msl = 6 [(mavsdk.options.default_value)="NaN"]; // Current altitude in metres (MSL) |
Collaborator
There was a problem hiding this comment.
Suggested change
| float altitude_msl = 6 [(mavsdk.options.default_value)="NaN"]; // Current altitude in metres (MSL) | |
| float absolute_altitude_m = 6 [(mavsdk.options.default_value)="NaN"]; // Current altitude in metres (MSL) |
Contributor
Author
There was a problem hiding this comment.
Sure thing
- absolute_altitude_m
Contributor
Author
There was a problem hiding this comment.
Done. See above.
julianoes
approved these changes
Feb 12, 2025
Collaborator
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
I think that's good like that, thanks!
Collaborator
|
@jonathanreeves the proto issues should be resolved with: mavlink/MAVSDK#2508 and #366. Thanks to @JonasVautherin for fixing it. |
Contributor
Author
Great thank you both! I'll re-base on top of that PR so it's ready to go. |
jonathanreeves
force-pushed
the
feature/attitude-and-fixed-wing
branch
from
24c4db0 to
15c1a10
Compare
julianoes
approved these changes
Feb 12, 2025
ddatsko
pushed a commit
to ddatsko/MAVSDK-Proto
that referenced
this pull request
Feb 17, 2025
* Updated FixedwingMetrics, added attitude and VFR_HUD publishers to the TelemetryServer * Re-order fields for backward compatibility * PR feedback: altitude_msl -> absolute_altitude_m --------- Co-authored-by: Jon Reeves <jon.reeves@elroyair.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to support the corresponding MAVSDK PR: mavlink/MAVSDK#2504
Specifically:
Note that currently MAVSDK does not build against Proto main. The MAVSDK PR listed above is using a branch of Proto with changes cherry-picked.