Add test for LinkType.setOutputType#389
Open
lacinoire wants to merge 3 commits intomaven-nar:masterfrom
Open
Conversation
GregDomjan
reviewed
Aug 13, 2022
Comment on lines
71
to
72
| final OutputTypeEnum pluginType = new OutputTypeEnum(); | ||
| pluginType.setValue("executable"); |
Member
There was a problem hiding this comment.
pluginType is not used as part of test for null, unecessary step
Author
|
Hey @GregDomjan, Thank you for the review 🙂 Hope the appveyor build goes through now 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 😊
I want to contribute a test.
Curious to hear what you think!
(I wrote this test as part of a research study at TU Delft. Find out more)