Fix the bug of spliting strings of configuration values.

[Haixing-Hu]

Some configuration parameters accept the space or comma separated values. For example, the defaultIncludes, defaultExcludes, optionSet, defineSet, undefineSet, and the compileOrder.

The Compiler.getCompiler() function will split those values and add them to the list of compiler arguments.

But the implementation of Compiler.getCompiler() failed to filter the empty sub-strings, and failed to trim the sub-strings, produced by the splitting.

This patch simply uses a regular expression as the separator to filter the empty sub-strings and trim the resulting sub-strings.

[buildhive]

NAR plugin for Maven » nar-maven-plugin #283 SUCCESS
This pull request looks good
(what's this?)

[buildhive]

NAR plugin for Maven » nar-maven-plugin #284 SUCCESS
This pull request looks good
(what's this?)

[dscho]

Thank you for your contribution! I offered some suggestions for improvements, hopefully I was clear. If not, or if you disagree, please do not hesitate to answer my concerns. Again, thanks for contributing to the NAR plugin!

[Haixing-Hu]

About the unit test.
Since the fields of the Compiler class was set by the IoC, and it provides no public setters nor getters. I have no idea about how to set the fields of a Compiler object in the unit test. Therefore I cannot provide an unit test for that patch.
Could you please give me some suggestions?

[dscho]

Could you please give me some suggestions?

I thought more about an integration test. Example: https://github.com/maven-nar/nar-maven-plugin/tree/master/src/it/it0003-jni

[dscho]

@Haixing-Hu still working on it?

[Haixing-Hu]

sorry that I'm working on a company project and was very busy these days.

I will continue work on the nar-maven-plugin project in my spare time.

在 2014年12月1日，下午5:23，dscho notifications@github.com 写道：

@Haixing-Hu https://github.com/Haixing-Hu still working on it?

—
Reply to this email directly or view it on GitHub #146 (comment).

[dscho]

I will continue work on the nar-maven-plugin project in my spare time.

We all do... All the contributors to the nar-maven-plugin, that is. Thank you for your time and efforts!