fix: pubdata is 0 error when using validium SL#4510
Open
sidhujag wants to merge 1 commit intomatter-labs:mainfrom
Open
fix: pubdata is 0 error when using validium SL#4510sidhujag wants to merge 1 commit intomatter-labs:mainfrom
sidhujag wants to merge 1 commit intomatter-labs:mainfrom
Conversation
when settling on a SL that is set to validium the pubdata is 0 but should be a minimum so the transaction is not rejected (0 is invalid)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
core/node/fee_model/src/l1_gas_price/gas_adjuster/mod.rs, updateestimate_effective_pubdata_priceso that forPubdataSendingMode::Customit returns a minimum of 800 (aligned withREQUIRED_L2_GAS_PRICE_PER_PUBDATA), preventing transaction rejections due to zero gas-per-pubdata.cap_pubdata_fee(no zeroing; only cap tomax_blob_base_fee).Reference: GitHub issue
#2105(noted in code comment).Why ❔
gas_per_pubdata = 0, which is invalid and leads to “gas per pub data limit is zero” rejection.REQUIRED_L2_GAS_PRICE_PER_PUBDATA = 800, ensuring cross-component consistency and successful settlement.PubdataSendingMode::Customand does not affect Rollup/blobs/calldata paths. Base fee remains governed byfair_l2_gas_priceunless pubdata cost dominates, which is unlikely at this floor.Is this a breaking change?
Rationale: Only affects Validium/Custom DA pubdata price when it would otherwise be zero. Rollup behavior and gateway fee paths remain unchanged. No interface changes.
Operational changes
internal_enforced_pubdata_priceinGasAdjusterConfig.Checklist
zkstack dev fmtandzkstack dev lint.