Fix plugin.json: remove invalid hooks/agents string paths (closes #1)#2
Open
vbutardo wants to merge 1 commit into
Open
Fix plugin.json: remove invalid hooks/agents string paths (closes #1)#2vbutardo wants to merge 1 commit into
vbutardo wants to merge 1 commit into
Conversation
The current Claude Code plugin schema rejects strings for the `agents` and `hooks` keys, causing /doctor to report: Plugin matsengrp-agents has an invalid manifest file at .claude-plugin/plugin.json. Validation errors: hooks: Invalid input, agents: Invalid input Both fields are unnecessary anyway: the agents/ directory and hooks/hooks.json already sit at the standard auto-discovery paths, so removing the redundant declarations restores manifest validity without changing behaviour. All 12 agents and the Notification/Stop hooks continue to load. Analogous to commit 960560a (marketplace.json source path format). Closes matsengrp#1
There was a problem hiding this comment.
Pull request overview
This pull request fixes .claude-plugin/plugin.json manifest validation by removing the agents and hooks fields that were previously provided as string paths, which the current Claude Code plugin schema rejects. The plugin’s agents and hooks continue to be discovered via the standard agents/ and hooks/hooks.json auto-discovery locations.
Changes:
- Removed invalid string-valued
agentsmanifest entry. - Removed invalid string-valued
hooksmanifest entry.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
Summary
/.claude-plugin/plugin.jsondeclaresagentsandhooksas string paths:The current Claude Code plugin schema rejects strings for these keys, so installing the plugin produces:
(see
claude /doctor). Both fields are unnecessary anyway — theagents/directory andhooks/hooks.jsonalready sit at the standard auto-discovery paths, so dropping them restores manifest validity without changing behaviour.Diff
"keywords": [ "scientific-writing", ... "bioinformatics" - ], - "agents": "agents/", - "hooks": "hooks/hooks.json" + ] }Test plan
python3 -c "import json; json.load(open('.claude-plugin/plugin.json'))"— JSON parsesclaude /doctor— passes (validated on a local copy with this patch applied)scientific-tex-editor,snakemake-pipeline-expert,pdf-question-answerer, etc.) still load via auto-discoveryNotification,Stop) inhooks/hooks.jsonstill fireContext
Analogous to commit 960560a ("Fix marketplace.json source path format"), which corrected a similar schema mismatch.
Submitted by Vito Butardo (vbutardo), Swinburne University of Technology.