Skip to content

Add stars layout#6907

Open
enot333lol333-coder wants to merge 3 commits into
mate-academy:masterfrom
enot333lol333-coder:master
Open

Add stars layout#6907
enot333lol333-coder wants to merge 3 commits into
mate-academy:masterfrom
enot333lol333-coder:master

Conversation

@enot333lol333-coder

Copy link
Copy Markdown
  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your Stars implementation correctly fulfills the functional requirements with proper BEM methodology, nth-child logic for active/inactive stars, and correct HTML structure. However, there are two checklist violations to address: 1) [CHECKLIST] The universal selector * for box-sizing should be replaced with html { box-sizing: border-box; } *, *::before, *::after { box-sizing: inherit; } to improve performance. 2) [CHECKLIST] Each BEM block should ideally have its own CSS file (e.g., stars.css), though for a single-block project, using style.css is acceptable. The visual regression differences (10-29%) suggest sizing/spacing adjustments are needed to match the reference design. You're on the right track—these are refinements rather than fundamental issues. Keep going!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/index.html
Comment on lines 1 to 2
<!doctype html>
<html lang="en">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checklist explicitly states 'Don't use * selector (it impacts performance)'. Replace with the standard box-sizing inheritance pattern: html { box-sizing: border-box; } *, *::before, *::after { box-sizing: inherit; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants