Add stars layout#6907
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your Stars implementation correctly fulfills the functional requirements with proper BEM methodology, nth-child logic for active/inactive stars, and correct HTML structure. However, there are two checklist violations to address: 1) [CHECKLIST] The universal selector * for box-sizing should be replaced with html { box-sizing: border-box; } *, *::before, *::after { box-sizing: inherit; } to improve performance. 2) [CHECKLIST] Each BEM block should ideally have its own CSS file (e.g., stars.css), though for a single-block project, using style.css is acceptable. The visual regression differences (10-29%) suggest sizing/spacing adjustments are needed to match the reference design. You're on the right track—these are refinements rather than fundamental issues. Keep going!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| <!doctype html> | ||
| <html lang="en"> |
There was a problem hiding this comment.
The checklist explicitly states 'Don't use * selector (it impacts performance)'. Replace with the standard box-sizing inheritance pattern: html { box-sizing: border-box; } *, *::before, *::after { box-sizing: inherit; }
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️