feat(nuget): add download option to source and implement repository_url#1781
Open
616b2f wants to merge 9 commits intomason-org:mainfrom
Open
feat(nuget): add download option to source and implement repository_url#1781616b2f wants to merge 9 commits intomason-org:mainfrom
616b2f wants to merge 9 commits intomason-org:mainfrom
Conversation
2 tasks
Author
|
The PR is ready for review, if you have questions or need me to adjust anything I am happy to do so :) |
Author
|
I will look into the new command UPDATE: So the PR stands with current solution. |
Author
|
I just realized that we need an issue first before I should create a PR, so I just created one. resolves #2045 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
A little bit of context for the PR:
I was looking into a way to be able to install a "regular" nuget package to be able to install the official roslyn LSP from Microsoft which is not hosted on nuget.org (for details see dotnet/roslyn#71474 (comment)).
The way currently nuget install works is we use "dotnet tool" to install nuget packages, but this works only with nuget packages which are "tools nuget packages" which means they have a specific structure and are for that also marked as tools in nuget repositories. When you try to install "regular" nuget packages via "dotnet tool" cli, it fails because the structure of the package is different and it expect it to be formatted as a tool.
In this PR I introduced two things that allow us to install any nuget package if the "package" author decides to do that:
After this PR we should be able to do this PR (mason-org/mason-registry#6330) for roslyn LSP in a more convenient way and more importantly to use the origin source for the LSP from the roslyn team.
This is my first PR here so please feel free to comment what I can improve or change.
PS: if possible we should squash the PR, because some commits where for a different solution initially which I abandoned when I came up with the current solution, but I thought it maybe helpful to keep it in the PR history.