Add speed profile 4 - #777
Merged
PartialVolume merged 2 commits intoJul 15, 2026
Merged
Conversation
For short duration wipes < 10 seconds that complete correctly just draw a flat line that represents average duration. This is really to take care of loop devices. Also validate the dataset and check the data is reasonable, i.e >= 0.0 and < 150000000000.0 (150GB) Currently fastest burst NVMe drives are 15GB/s so have allowed 10 times current speeds. If drive speeds should ever get close to 150GB/s then MAX_LIMIT will need to be increased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidy up of edge cases for speed profile graph
For short duration wipes < 10 seconds that complete correctly
just draw a flat line that represents average duration. This
is really to take care of loop devices.
Also validate the dataset and check the data is reasonable, i.e
If drive speeds should ever get close to 150GB/s then MAX_LIMIT
will need to be increased.
Update user notes on speed profile page
Fixes a bug that happens when a user aborts a wipe, the graph would become corrupted and the PDF would grow from ~600K to 30MB