-
Notifications
You must be signed in to change notification settings - Fork 7
Spelling #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsoref
wants to merge
8
commits into
marp-team:master
Choose a base branch
from
jsoref:spelling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spelling #10
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
37c4ee2
spelling: discussion
jsoref d349963
spelling: enhancing
jsoref 5d9a6ac
spelling: for that
jsoref 70bd56b
spelling: github
jsoref ef3e21b
spelling: maintainability
jsoref dc073ed
spelling: occurred
jsoref 7264add
spelling: official
jsoref 96e6382
spelling: to ask questions
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ Thank you for taking the time to read how to contribute to our project! This is | |||||
|
|
||||||
| You can start contributing our project in several ways: improve docs, report bug, request feature, writing code, and so on. | ||||||
|
|
||||||
| Depending on the project you want to contribute, it might have additional guidelines you should follow at that repository. Please also check the guideline per repository. | ||||||
| Depending on the project you want to contribute, it might have additional guidelines you should follow for that repository. | ||||||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| > :information_source: Would you the first time to contribute OSS? [Open Source Guides](https://opensource.guide/how-to-contribute/) might help you. | ||||||
|
|
||||||
|
|
@@ -14,7 +14,7 @@ We follow [Contributor Covenant Code of Conduct][code-of-conduct] in the all of | |||||
|
|
||||||
| ## Our position | ||||||
|
|
||||||
| For simplicity and long-maintainabillity of the ecosystem, Marp team is focusing just to the experience of slide authoring. | ||||||
| For simplicity and long-maintainability of the ecosystem, Marp team is focusing just to the experience of slide authoring. | ||||||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this would be better as:
Suggested change
|
||||||
|
|
||||||
| Team members should avoid to bring [scope creep] and bloated project scope in the ecosystem. If not, the ecosystem would end up burning out, just like a [former Marp app](https://github.com/yhatt/marp). | ||||||
|
|
||||||
|
|
@@ -81,9 +81,9 @@ You can submit pull request if you have fixed or added useful something to our p | |||||
|
|
||||||
| ### Before adding new feature | ||||||
|
|
||||||
| _Marp team is not proactive for enhanceing our syntax_, because the custom Markdown flavor may make user's confusions and protests whose are familiar with exist Markdown/CommonMark syntax. | ||||||
| _Marp team is not proactive for enhancing our syntax_, because the custom Markdown flavor may make user's confusions and protests whose are familiar with exist Markdown/CommonMark syntax. | ||||||
|
|
||||||
| We are always suggesting **"Use or create the third-party [plugin](https://marpit.marp.app/usage?id=extend-marpit-by-plugins) if you want"** rather than adding new syntax. For implementing new syntax and new feature to offical tools, we require able to confirm a worth through a created third-party plugin and many real-world presentations using it. We will consider integrating the plugin as built-in feature if the most of Marp community shows that using the plugin is valuable. | ||||||
| We are always suggesting **"Use or create the third-party [plugin](https://marpit.marp.app/usage?id=extend-marpit-by-plugins) if you want"** rather than adding new syntax. For implementing new syntax and new feature to official tools, we require able to confirm a worth through a created third-party plugin and many real-world presentations using it. We will consider integrating the plugin as built-in feature if the most of Marp community shows that using the plugin is valuable. | ||||||
|
|
||||||
| ### [Good first issues](https://github.com/search?q=org%3Amarp-team+is%3Aopen+label%3A%22good+first+issue%22) | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the sentence I'm removing added any value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added to emphasize existence of repository-specific guideline. If not, some of contributors may miss that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My proposal: https://github.com/marp-team/.github/pull/10/files#r2258128584