Open
Conversation
timezone-aware version of date-fns.add
Owner
|
Thank you @dr-skot, I'll take a look in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love this library. One feature it's missing that I've needed from time to time is a timezone-aware version of the date-fns
addfunction.Time zones matter in date arithmetic because of daylight savings. If your base time is 2022-11-05T06:00Z, for example, and you want to add one day,
in LA it's
11pm Nov 4 + 1 day === 11pm Nov 5 === +24 hrs
but in Halifax it's
3am Nov 5 + 1 day === 3am Nov 6 === +25 hrs
because the clocks fall back 1 hr (in both places) at 2am Nov 6.
So here's a proposed
addInTimeZonefunction to handle that. Plus some tests.I tried
yarn buildto generate the typings files but no joy. I guess some more configuration twiddling is needed to make that work.Hope you find it useful!