Skip to content

Fix: normalize WorldSpaceViewDirection in OceanFramework_Generated.shader#1433

Open
marko1olo wants to merge 1 commit into
mainfrom
fix-ocean-shader-view-direction-14638131206555107651
Open

Fix: normalize WorldSpaceViewDirection in OceanFramework_Generated.shader#1433
marko1olo wants to merge 1 commit into
mainfrom
fix-ocean-shader-view-direction-14638131206555107651

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

Addresses a TODO where WorldSpaceViewDirection was normalized by default in HD but not in Universal. Now normalize(input.viewDirectionWS) is used explicitly across all passes.


PR created automatically by Jules for task 14638131206555107651 started by @marko1olo

…ader

Addresses a TODO where WorldSpaceViewDirection was normalized by default in HD but not in Universal. Now normalize(input.viewDirectionWS) is used explicitly across all passes.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant