Skip to content

Fix UnityObject reference serialization in Placeholders#1420

Open
marko1olo wants to merge 1 commit into
mainfrom
jules-16878339498043222893-61687992
Open

Fix UnityObject reference serialization in Placeholders#1420
marko1olo wants to merge 1 commit into
mainfrom
jules-16878339498043222893-61687992

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

🎯 What: Implemented serialization of UnityObject references inside the MapMagic.Nodes.Placeholders by storing origUniObj inside GenericPlaceholder and assigning it manually to SerObject inside the custom serialization hooks.
💡 Why: UnityObject references were not being serialized (as mentioned by the TODO), preventing proper saving of GenericPlaceholder nodes.
Verification: Verified compilation and no regression by running full verify sweep.
Result: Placeholders now correctly serialize UnityObject references.


PR created automatically by Jules for task 16878339498043222893 started by @marko1olo

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant