Conversation
|
@UziTech is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @UziTech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where empty list items were not being correctly parsed or rendered. It refactors the regular expressions responsible for identifying bullet points and list structures to properly handle leading spaces. This ensures that empty list items are correctly processed, as demonstrated by the newly added test cases, resolving the reported bug. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where an empty list item could be misinterpreted as a setext heading. The fix is implemented by modifying the regular expressions in src/rules.ts. Specifically, the optional indentation ( {0,3}) is moved from the list rule's definition into the bullet rule itself. This refactoring makes the bullet rule more self-contained and accurate. As a consequence, rules like lheading that use bullet in negative lookaheads are now better able to distinguish list items from setext underlines, which resolves the parsing error. The addition of new test files for empty list items is a great way to verify the fix and prevent regressions. The changes are logical, well-targeted, and improve the parser's correctness.
calculuschild
left a comment
There was a problem hiding this comment.
Makes sense. Good fix.
## [17.0.2](v17.0.1...v17.0.2) (2026-02-11) ### Bug Fixes * fix blockquote after list ([#3888](#3888)) ([2a475a1](2a475a1)) * fix empty list item ([#3890](#3890)) ([3fc6a44](3fc6a44)) * fix list item wrong indent ([#3889](#3889)) ([e031175](e031175)) * fix list with tabs ([#3891](#3891)) ([9fc4f8e](9fc4f8e)) * fix strikethrough flanking rules ([#3882](#3882)) ([1a5b124](1a5b124))
Marked version: 17.0.1
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.