Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/herb/engine/compiler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,14 @@ def process_erb_tag(node, skip_comment_check: false)
end
return if erb_graphql?(opening)

code = node.content.value.strip
raw_content = node.content.value
code = raw_content.strip

if erb_output?(opening)
process_erb_output(node, opening, code)
else
code = "\n#{code}" if raw_content.start_with?("\n")
code = "#{code}\n" if raw_content.match?(/\n[ \t]*\z/)
apply_trim(node, code)
end
end
Expand Down Expand Up @@ -590,7 +593,11 @@ def apply_trim(node, code)
if at_line_start?
leading_space = extract_and_remove_leading_space!
effective_leading_space = leading_space.empty? ? removed_whitespace : leading_space
right_space = Herb::Engine.heredoc?(code) ? "\n" : " \n"
right_space = if code.end_with?("\n") || Herb::Engine.heredoc?(code)
"\n"
else
" \n"
end

@pending_leading_whitespace_insert_index = @tokens.length
@pending_leading_whitespace = effective_leading_space if !effective_leading_space.empty? && follows_newline
Expand Down
12 changes: 12 additions & 0 deletions test/engine/whitespace_trimming_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -364,5 +364,17 @@ class WhitespaceTrimmingTest < Minitest::Spec
assert_compiled_snapshot(template)
assert_evaluated_snapshot(template, enforce_erubi_equality: true)
end

test "multi-line code block preserves line count parity with erubi" do
template = "<%\n x = 1\n y = 2\n%>\n<%= x %>"

herb_engine = assert_compiled_snapshot(template)
erubi_engine = Erubi::Engine.new(template)

assert_equal erubi_engine.src.lines.count, herb_engine.src.lines.count,
"Herb should preserve line count for multi-line code blocks.\n " \
"Erubi (#{erubi_engine.src.lines.count} lines): #{erubi_engine.src.inspect}\n " \
"Herb (#{herb_engine.src.lines.count} lines): #{herb_engine.src.inspect}"
end
end
end

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading