Update marbl_ciso_surface_flux_mod.F90#465
Open
jlinmod wants to merge 2 commits intomarbl-ecosys:stablefrom
Open
Update marbl_ciso_surface_flux_mod.F90#465jlinmod wants to merge 2 commits intomarbl-ecosys:stablefrom
jlinmod wants to merge 2 commits intomarbl-ecosys:stablefrom
Conversation
comment and eps_aq_g equation fix
Collaborator
|
@jlinmod -- sorry for the delayed response. The Zhang et al. paper offers two different values for the temperature coeffficient when computing
However, in Figure 2 they use
Further, the slope of the line in Figure 2 is positive, which makes us think that the figure caption is the correct value to use. Rather than close this PR, could you revert line 155 to drop the minus sign? I think the clean-up you did to the comments is valuable and we'd be happy to bring those changes in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comment and eps_aq_g equation fix