Remove workaround to PGI compiler bug#327
Open
mnlevy1981 wants to merge 2 commits intomarbl-ecosys:developmentfrom
Open
Remove workaround to PGI compiler bug#327mnlevy1981 wants to merge 2 commits intomarbl-ecosys:developmentfrom
mnlevy1981 wants to merge 2 commits intomarbl-ecosys:developmentfrom
Conversation
As of 18.10, put_input_file_line() does not need the pgi_bugfix_var optional argument to be recognized as a unique interface for put_setting(). Once this is accepted onto development, PGI 18.4 (and earlier) will not be able to compile MARBL. It will fail to build the stand-alone driver with the error PGF90-S-0155-cannot access PRIVATE type bound procedure put_input_file_line (Presumably GCMs that use put_setting() will also run into this error)
Collaborator
Author
|
I've asked ISG to install the newest PGI compiler on hobart, at which point I'll make a CIME pull request to update the version used by CESM... after CESM is building with 18.10, we can bring this onto development and stable (assuming the CIME change goes into both CESM 2.1 and 2.2) |
Without the pgi bug workaround, the stand-alone test suite needs to build with the version 18.10 of the compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 18.10, put_input_file_line() does not need the pgi_bugfix_var optional
argument to be recognized as a unique interface for put_setting(). Once this is
accepted onto development, PGI 18.4 (and earlier) will not be able to compile
MARBL. It will fail to build the stand-alone driver with the error
(Presumably GCMs that use put_setting() will also run into this error)