std::vector -> std::array for constant#14154
Open
Dushistov wants to merge 1 commit intomapsme:masterfrom
Open
Conversation
`std::vector` is not very well suited for static, constant arrays.
Since creating it from a list requires memory allocation,
modern C++ compilers miss out on many optimizations.
In particular, compilers are forced to insert a call to a global
atomic variable and a bunch of code for initialization at the place of
its use. Plus access to heap memory cause cache misses
For example for this function:
bool f(const int *arr, int x)
{
static std::vector<Foo> const values = {A, B, C};
for (auto v : values) {
if (arr[static_cast<size_t>(v)] == x)
return true;
}
return false;
}
compiler generates ~60 instructions (gcc 10.2 -O3 -march=native),
if replace `std::vector` with `std::array` the result code contains only 9 instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::vectoris not very well suited for static, constant arrays.Since creating it from a
std::initializer_listrequires memory allocation,modern C++ compilers miss out on many optimizations.
In particular, compilers are forced to insert a call to a global
atomic variable and a bunch of code for initialization of
std::vector.Plus access to heap memory cause cache misses.
For example for this function:
compiler generates ~60 instructions (gcc 10.2 -O3 -march=native),
if replace
std::vectorwithstd::arraythe result code contains only 9 instructions.