Skip to content

Implement continuous mode#112

Closed
Murmele wants to merge 22 commits intomaplibre:mainfrom
Murmele:rust_compilation_bug
Closed

Implement continuous mode#112
Murmele wants to merge 22 commits intomaplibre:mainfrom
Murmele:rust_compilation_bug

Conversation

@Murmele
Copy link
Collaborator

@Murmele Murmele commented Dec 5, 2025

This PR is far away from being finished, but maybe someone can have a look on it and provide feedback.
Implement continuous mode with map and renderer observer.

Not working

  • didFinishRenderingFrameTrampolineFunction crashes when called
  • setSize still crashes
  • renderer observer callback gets never called

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Murmele and others added 22 commits November 16, 2025 13:02
@Murmele
rustc index out of range
1ef8745
@Murmele
add possiblity to add a custom observer
02e70ac
@Murmele
get it compiled with a callback
118238a
@Murmele
fix using callback
d38feb3 
Reason: previously the wrong callback was used
@Murmele
rerun also for renderer_observer.h and map_observer.h changes
ad938eb
@Murmele
enu must be in the same namespace than on the C++ side
ed15ff6 
Reason: otherwise the static_assertion checks are wrong
@Murmele
add comment
3ac66dd
@Murmele
add also a map_observer and implement native Renderer and MapObserver…
93afeb9 
… to have a more fluent usage
@Murmele
add render_once function
ed79d06
@Murmele
use trampoline objects to be able to use closures as callbacks
a651b45
@Murmele
Fix segfault
8aaf04d 
Reason: the MapObserver Instance got deleted after the MapRenderer_new_with_observer call, because the variable which has the pointer to the MapObserver gets deleted and then also the references pointing on it are invalid
@Murmele
cleanup
b0c9d6a
@Murmele
remove example
83a0e80 
Reason: unintentionally added. It does nothing
@Murmele
make all functions for the trampoline static
4f54eb6 
Reason: Otherwise we have a livetime problem if the function is not static. For Closures move must be used to capture all variables by value!
@Murmele
set log level to trace
6b3dce2
@Murmele
add function to read still image from the renderer
bc62d44
@Murmele
add comment
3be258d
@Murmele
add possibility to set the camera
fdd8855 
Reason: because it is important to set it
@Murmele
add comment
0255123
@Murmele
implement interaction
b5e2245
@Murmele
add more
b4832d4
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
14be869 
for more information, see https://pre-commit.ci
@Murmele Murmele closed this Dec 5, 2025
@CommanderStorm
Copy link
Member

CommanderStorm commented Dec 5, 2025

@Murmele you closed the PR, was this intentional?

@Murmele
Copy link
Collaborator Author

Murmele commented Dec 5, 2025

@CommanderStorm I found a simpler way for the Callback and I have to rework. I just crossed over that functionallity right after I opened the PR. I will reopen once I refactored

@Murmele
Copy link
Collaborator Author

Murmele commented Dec 9, 2025

I had to create a new PR, because I am not able to open this one again #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Murmele @CommanderStorm