Fix local icons (update deprecated globEager) #1
Open
philmillman wants to merge 1 commit intomanuelmeister:mainfrom
Open
Fix local icons (update deprecated globEager) #1philmillman wants to merge 1 commit intomanuelmeister:mainfrom
philmillman wants to merge 1 commit intomanuelmeister:mainfrom
Conversation
|
@philmillman is attempting to deploy a commit to the manuelmeister's projects Team on Vercel. A member of the Team first needs to authorize it. |
philmillman
commented
Nov 19, 2025
|
|
||
| try { | ||
| const files = import.meta.globEager("/src/icons/**/*.svg", { as: "raw" }); | ||
| const files = import.meta.glob("/src/icons/**/*.svg", { query: "?raw", import: "default", eager: true }); |
Author
There was a problem hiding this comment.
the query part might be unnecessary but I was trying to keep it as close to the original as possible
Author
|
sample error before the fix: 
|
Author
|
cc: @manuelmeister ^^ |
Owner
|
@philmillman sorry, I'm not sure how I want to continue with this package. It depends how I'm going to update ecamp/ecamp-site |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
local icons were broken for me, I'm assuming this because the Vite version in my repo is newer (7.x)
tested with the demo and all seems to work fine!