Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a new board configuration file that declares three exported constants: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
…lder 6.6 kernel Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@configs/board-longan_pi3h_bookworm.conf`:
- Around line 1-3: The ARMBIAN_BRANCH value is invalid; update the
ARMBIAN_BRANCH variable in the config (look for the ARMBIAN_BRANCH="v25.05" line
in the file) to a valid upstream tag such as "v25.5.1", "v25.8.1", or "v25.8.2"
(choose the appropriate release for your build), ensuring the string exactly
matches an existing tag in the armbian/build repo so the build can find the
correct upstream sources.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cd003237-943e-40ed-9767-11b99a539c7d
📒 Files selected for processing (1)
configs/board-longan_pi3h_bookworm.conf
| BOARD=longanpi-3h | ||
| RELEASE="bookworm" | ||
| ARMBIAN_BRANCH="v25.05" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
cfg="$(fd 'board-longan_pi3h_bookworm.conf' | head -n1)"
board="$(sed -nE 's/^BOARD="?([^"]+)"?$/\1/p' "$cfg")"
branch="$(sed -nE 's/^ARMBIAN_BRANCH="?([^"]+)"?$/\1/p' "$cfg")"
echo "Config file: $cfg"
echo "BOARD=$board"
echo "ARMBIAN_BRANCH=$branch"
# Expected: tag exists
git ls-remote --exit-code --tags https://github.com/armbian/build.git "refs/tags/$branch" >/dev/null
echo "OK: tag '$branch' exists in armbian/build"
# Expected: at least one board config path contains the board id
python - "$branch" "$board" <<'PY'
import json, sys, urllib.request
branch, board = sys.argv[1], sys.argv[2]
url = f"https://api.github.com/repos/armbian/build/git/trees/{branch}?recursive=1"
with urllib.request.urlopen(url) as r:
data = json.load(r)
paths = [n.get("path","") for n in data.get("tree",[])]
matches = [p for p in paths if p.startswith("config/boards/") and board.lower() in p.lower()]
if not matches:
print(f"FAIL: no board config containing '{board}' found under config/boards at {branch}")
sys.exit(1)
print("OK: matching board config path(s):")
for m in matches[:10]:
print(" -", m)
PYRepository: mainsail-crew/armbian-builds
Length of output: 164
🏁 Script executed:
#!/bin/bash
# Check tag existence separately
echo "=== Checking if tag v25.05 exists in armbian/build ==="
git ls-remote --tags https://github.com/armbian/build.git 2>&1 | grep -E 'v25\.05|^fatal|^error' || echo "No match found or connection issue"
echo -e "\n=== Checking available tags near v25.05 ==="
git ls-remote --tags https://github.com/armbian/build.git 2>&1 | grep -E 'v25\.' | tail -20 || echo "Could not fetch tags"Repository: mainsail-crew/armbian-builds
Length of output: 1552
🏁 Script executed:
#!/bin/bash
# Alternative: check the GitHub API directly for tag v25.05
python3 <<'PYEOF'
import json
import urllib.request
import urllib.error
try:
# Check if the tag exists via GitHub API
url = "https://api.github.com/repos/armbian/build/git/ref/tags/v25.05"
req = urllib.request.Request(url)
with urllib.request.urlopen(req) as response:
data = json.load(response)
print("Tag v25.05 EXISTS")
print(f"SHA: {data.get('object', {}).get('sha', 'N/A')}")
except urllib.error.HTTPError as e:
if e.code == 404:
print("ERROR: Tag v25.05 NOT FOUND in armbian/build")
else:
print(f"HTTP Error {e.code}: {e.reason}")
except Exception as e:
print(f"Error checking tag: {e}")
PYEOFRepository: mainsail-crew/armbian-builds
Length of output: 219
Replace invalid ARMBIAN_BRANCH="v25.05" with a valid upstream tag.
The tag v25.05 does not exist in the armbian/build repository. Valid tags in the v25 series include v25.5.1, v25.8.0-trunk.*, v25.8.1, and v25.8.2. Choose an appropriate release tag before merge to prevent build failures.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@configs/board-longan_pi3h_bookworm.conf` around lines 1 - 3, The
ARMBIAN_BRANCH value is invalid; update the ARMBIAN_BRANCH variable in the
config (look for the ARMBIAN_BRANCH="v25.05" line in the file) to a valid
upstream tag such as "v25.5.1", "v25.8.1", or "v25.8.2" (choose the appropriate
release for your build), ensuring the string exactly matches an existing tag in
the armbian/build repo so the build can find the correct upstream sources.
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
1 participant
No description provided.