fix(cli): error on conflicting --show-artifacts and --no-artifacts - #42
Conversation
Passing --show-artifacts together with --no-artifacts asked the scan to render artifact detail sections while artifact detection was disabled, producing empty output. The scan command now validates the combination up front and exits with a clear error message. Adds a CLI test covering the rejected combination. Co-authored-by: Riya Bajpai <riyabajpai22ndapril@gmail.com>
|
Warning Review limit reached
Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reimplements #21 by @Riyaa-Bajpai on top of the current
mainlayout.Problem
Passing
--show-artifactstogether with--no-artifactstoenvoic scanasked the report to render artifact-detail sections while artifact detection
was disabled, producing empty artifact output instead of a clear error.
Fix
scannow validates the combination up front and exits with code 1 and aclear message:
Why a new PR instead of updating #21
#21 was opened against the pre-monorepo layout (it edits
src/envoic/cli.py,which is now
packages/python/src/envoic/cli.py) and was 33 commits behindmain, so it could not be rebased cleanly. Its code also had anIndentationError and a misplaced test. This PR keeps the original intent and
credits Riya as co-author.
Tests
packages/python/tests/test_cli.pycovering the rejected combination andthe still-valid
--show-artifacts(default artifacts) case.