Skip to content

fix(cli): error on conflicting --show-artifacts and --no-artifacts - #42

Merged
mahimairaja merged 1 commit into
mainfrom
fix/conflicting-artifact-flags
Jun 30, 2026
Merged

fix(cli): error on conflicting --show-artifacts and --no-artifacts#42
mahimairaja merged 1 commit into
mainfrom
fix/conflicting-artifact-flags

Conversation

@mahimairaja

Copy link
Copy Markdown
Member

Reimplements #21 by @Riyaa-Bajpai on top of the current main layout.

Problem

Passing --show-artifacts together with --no-artifacts to envoic scan
asked the report to render artifact-detail sections while artifact detection
was disabled, producing empty artifact output instead of a clear error.

Fix

scan now validates the combination up front and exits with code 1 and a
clear message:

Error: --show-artifacts cannot be used together with --no-artifacts.

Why a new PR instead of updating #21

#21 was opened against the pre-monorepo layout (it edits src/envoic/cli.py,
which is now packages/python/src/envoic/cli.py) and was 33 commits behind
main, so it could not be rebased cleanly. Its code also had an
IndentationError and a misplaced test. This PR keeps the original intent and
credits Riya as co-author.

Tests

  • New packages/python/tests/test_cli.py covering the rejected combination and
    the still-valid --show-artifacts (default artifacts) case.
  • Full suite: 49 passed. ruff lint + format + pre-commit hooks pass.

Passing --show-artifacts together with --no-artifacts asked the scan to
render artifact detail sections while artifact detection was disabled,
producing empty output. The scan command now validates the combination
up front and exits with a clear error message.

Adds a CLI test covering the rejected combination.

Co-authored-by: Riya Bajpai <riyabajpai22ndapril@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mahimairaja, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 944ffcf6-8660-4223-962d-16dbae836c55

📥 Commits

Reviewing files that changed from the base of the PR and between 540df9b and 57e16d0.

📒 Files selected for processing (2)
  • packages/python/src/envoic/cli.py
  • packages/python/tests/test_cli.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/conflicting-artifact-flags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mahimairaja
mahimairaja merged commit 9a60fc8 into main Jun 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant