Fix undefined 'directory' variable in Sigma rule generation#281
Open
Fix undefined 'directory' variable in Sigma rule generation#281
Conversation
The _write_rule nested function referenced 'directory' but gen_sigma_rule_per_driver never received it as a parameter. Pass output_dir from the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NameError: name 'directory' is not definedinbin/gen-files.pywhen generating per-driver Sigma rules_write_rulenested function referenceddirectorybutgen_sigma_rule_per_driver()never received it as a parameteroutput_dirfrom the callergen_sigma_rules_per_driver()Test plan
poetry run python bin/gen-files.pyand verify Sigma rule generation completes without errors