fix(ui): remove duplicate Advanced settings and consolidate rotation/export (#1497)#1502
Open
AdityaNarayanPadhi wants to merge 1 commit into
Open
Conversation
|
@AdityaNarayanPadhi is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Contributor
👋 Thanks for your PR, @AdityaNarayanPadhi!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:intermediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes duplicate collapsible "Advanced settings" panels and resolves HTML ID collisions and screen-reader accessibility violations in
VideoEditor.tsx(#1497).Changes
<details>block and duplicate standaloneRotationcontrol from the first column.Exportcontrol from the second column.RotationandExportcontrols inside a single, unified "Advanced settings" details section at the bottom of the second column.Verification
rotation-panel,export-panel) is now unique, restoring proper W3C validation and screen-reader/keyboard focus handling.