Fix btoa emoji crash#1485
Open
divyansha12 wants to merge 2 commits into
Open
Conversation
|
@divyansha12 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Contributor
👋 Thanks for your PR, @divyansha12!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @magic-peach
Description
Fixes a fatal
DOMExceptioncrash when clicking "Copy Link" after adding a text overlaycontaining emojis or non-ASCII characters. The native
btoa()only accepts Latin1 characters,so emoji in the JSON string caused an immediate unhandled exception with no user feedback.
Fix: Wraps
JSON.stringify(recipe)withencodeURIComponent+unescapebeforebtoa(), and decodes symmetrically withescape+decodeURIComponentafteratob().Exports
encodeRecipefromuseVideoEditor.tsand uses it inVideoEditor.tsx'shandleCopyLink, replacing the crashing directbtoa()call.Related Issue
Closes #1469
Type of Contribution
Participant Info
Checklist
console.logstatements left in