Skip to content

fix: resolve log listener cleanup issue in ffmpeg.worker.ts#1484

Open
riya-chauhan12 wants to merge 1 commit into
magic-peach:mainfrom
riya-chauhan12:fix-loglistener-cleanup
Open

fix: resolve log listener cleanup issue in ffmpeg.worker.ts#1484
riya-chauhan12 wants to merge 1 commit into
magic-peach:mainfrom
riya-chauhan12:fix-loglistener-cleanup

Conversation

@riya-chauhan12
Copy link
Copy Markdown

Description

Fixed a log listener cleanup issue in src/lib/ffmpeg.worker.ts.

The non-GIF export flow declared a new logListener variable that shadowed the outer variable used during cleanup. This prevented the same listener reference from being used for both registration and cleanup.

Changes Made

- const logListener = ({ message }: { message: string }) => {
+ logListener = ({ message }: { message: string }) => {

This ensures the same listener reference is used for both ffmpeg.on("log", ...) and ffmpeg.off("log", ...).

Related Issue

Closes #1460

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: riya-chauhan12
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screen Recording

N/A – Internal logic fix with no visible UI changes.

Recording / Loom link: N/A

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

✅ PR Format Check Passed — @riya-chauhan12

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

👋 Thanks for your PR, @riya-chauhan12!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Potential log listener cleanup issue due to variable shadowing in ffmpeg.worker.ts

1 participant