Skip to content

fix: notify user when export falls back to WebM#1479

Open
Harshith1702 wants to merge 3 commits into
magic-peach:mainfrom
Harshith1702:Harshith1702-30
Open

fix: notify user when export falls back to WebM#1479
Harshith1702 wants to merge 3 commits into
magic-peach:mainfrom
Harshith1702:Harshith1702-30

Conversation

@Harshith1702

Copy link
Copy Markdown
Contributor

Fixes #30

MP4 fails silently and exports as WebM with zero indication to the user.
This fixes that.

Changes:

  • types.ts: added usedFallback and fallbackReason as optional fields on ExportResult
  • ffmpeg.ts: compare recipe.format vs actual output format after export, tag result if they differ
  • DownloadResult.tsx: render a warning banner when usedFallback is true

VideoEditor.tsx untouched, already passes the full result object down.

@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

@Harshith1702 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Harshith1702

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix labels Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Harshith1702!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@Harshith1702

Copy link
Copy Markdown
Contributor Author

Hey @magic-peach it's been 2 weeks...., any review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] WebM fallback silently changes output format without user notification

1 participant