fix: Large Video Uploads Can Freeze or Crash Browser During Waveform Generation#1471
Open
Krishnx21 wants to merge 2 commits into
Open
fix: Large Video Uploads Can Freeze or Crash Browser During Waveform Generation#1471Krishnx21 wants to merge 2 commits into
Krishnx21 wants to merge 2 commits into
Conversation
|
@Krishnx21 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Krishnx21Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Krishnx21!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
@magic-peach can you please check this and let me know what i have to enhance ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a performance and stability issue where large uploaded videos were fully loaded into memory and decoded immediately for waveform generation.
Problem
Previously, waveform generation started automatically whenever
TrimControlmounted. Large video files (400–500 MB) were read entirely into memory usingfile.arrayBuffer()and decoded viadecodeAudioData(), even if the user never opened the trim feature.This behavior could lead to:
Changes Made
Testing
Verified the following scenarios:
Impact
This fix significantly improves the user experience when working with large video files by reducing unnecessary memory allocation and preventing browser freezes or crashes during project initialization.
Closes #1450