Open
Conversation
|
Good suggestion, can this be merged? |
Owner
|
What is wrong with the v3 style? |
Collaborator
|
@mafintosh I had suggested it in the context of changes in #53. It makes more sense to have the examples reflect the intended usage. With tools like |
LinusU
reviewed
Aug 13, 2018
|
|
||
| t.ok(validate({hello: 'world'}), 'should be valid') | ||
| t.notOk(validate(), 'should be invalid') | ||
| t.notOk(validate(null), 'should be invalid') |
Collaborator
There was a problem hiding this comment.
can we keep the previous one as well? would be nice to test both undefined and null
Collaborator
|
I think that recommending the latest version is the best, that's the one I've seen most tutorial and other libraries use 👍 @jonasfj sorry for not looking at this earlier, would be happy to merge if you could address my comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #53 (comment)
I still suggest (strongly that we merge the original PR), so people can disable support for
requiredv3-style... and have errors thrown when calling with undefined.I think it's a solid preparation for a future major release where you fully disable v3-style
required.