chore: Remove umami tracking code#27
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes the Umami tracking code from the application. This change enhances user privacy by eliminating external analytics dependencies and simplifies the client-side codebase by removing the associated script and updating the Content-Security-Policy. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes the Umami tracking code by deleting the script from the base layout and updating the Content Security Policy. The changes are straightforward and achieve the stated goal. I have added one comment regarding a potential security enhancement for the CSP to make it more strict, which you might want to consider for a future improvement.
| w.Header().Set("Content-Security-Policy", strings.TrimSpace(` | ||
| default-src 'self'; | ||
| script-src 'self' 'unsafe-eval' 'unsafe-inline' cdn.jsdelivr.net umami.coderustle.dev; | ||
| script-src 'self' 'unsafe-eval' 'unsafe-inline' cdn.jsdelivr.net; |
There was a problem hiding this comment.
While this PR correctly removes the Umami-related domain, the script-src directive still contains 'unsafe-eval' and 'unsafe-inline'. These keywords pose a significant security risk by increasing the attack surface for Cross-Site Scripting (XSS) vulnerabilities. It is highly recommended to remove them.
To address this:
- For
'unsafe-inline', consider moving inline scripts to external files or using a nonce-based/hash-based approach for any scripts that must remain inline. - For
'unsafe-eval', you may need to refactor parts of the application that rely oneval()or similar functions. Libraries like Alpine.js can sometimes require this, but it's worth investigating if a more secure configuration is possible, for example by using a build step.
|
Closes #25 |
No description provided.