Skip to content

chore: Remove umami tracking code#27

Merged
madalinpopa merged 1 commit intomainfrom
branch/push-znkyqqtvrlsv
Mar 8, 2026
Merged

chore: Remove umami tracking code#27
madalinpopa merged 1 commit intomainfrom
branch/push-znkyqqtvrlsv

Conversation

@madalinpopa
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the Umami tracking code from the application. This change enhances user privacy by eliminating external analytics dependencies and simplifies the client-side codebase by removing the associated script and updating the Content-Security-Policy.

Highlights

  • Removed Umami Analytics Script: The <script> tag responsible for loading the Umami analytics client was removed from the base HTML template.
  • Updated Content-Security-Policy: The Content-Security-Policy was modified to no longer allow connections to or scripts from the umami.coderustle.dev domain.
Changelog
  • internal/interfaces/web/middleware.go
    • Removed umami.coderustle.dev from the script-src and connect-src directives within the Content-Security-Policy header.
  • ui/templates/layouts/base.templ
    • Deleted the <script> tag that embedded the Umami analytics tracking code.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the Umami tracking code by deleting the script from the base layout and updating the Content Security Policy. The changes are straightforward and achieve the stated goal. I have added one comment regarding a potential security enhancement for the CSP to make it more strict, which you might want to consider for a future improvement.

w.Header().Set("Content-Security-Policy", strings.TrimSpace(`
default-src 'self';
script-src 'self' 'unsafe-eval' 'unsafe-inline' cdn.jsdelivr.net umami.coderustle.dev;
script-src 'self' 'unsafe-eval' 'unsafe-inline' cdn.jsdelivr.net;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this PR correctly removes the Umami-related domain, the script-src directive still contains 'unsafe-eval' and 'unsafe-inline'. These keywords pose a significant security risk by increasing the attack surface for Cross-Site Scripting (XSS) vulnerabilities. It is highly recommended to remove them.

To address this:

  • For 'unsafe-inline', consider moving inline scripts to external files or using a nonce-based/hash-based approach for any scripts that must remain inline.
  • For 'unsafe-eval', you may need to refactor parts of the application that rely on eval() or similar functions. Libraries like Alpine.js can sometimes require this, but it's worth investigating if a more secure configuration is possible, for example by using a build step.

@madalinpopa
Copy link
Copy Markdown
Owner Author

Closes #25

@madalinpopa madalinpopa merged commit 0bb17eb into main Mar 8, 2026
6 checks passed
@madalinpopa madalinpopa deleted the branch/push-znkyqqtvrlsv branch March 8, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant