Fix assets path to fix admin entity editing#192
Open
Pluies wants to merge 1 commit intolyft:masterfrom
Open
Conversation
Contributor
|
So Can you share screenshots to help us understand/replicate what's broken ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
I was trying to get entity editing to work as per the README under Gateway Admin UI), but the page at
https://<presto-gateway>/entity/ended up broken. I realised that CSS / JS resources weren't loading because the template references assets via relative path, and the admin page is located at/entity. The relative path therefore ends up being/entity/assets/...which receives a 404.The attached PR fixes this by setting an absolute path for
/assets, rather than relative.(Note: I assume that this is the correct thing to do, but I'm not 100% sure as the docs don't actually specify the URL for the admin page - maybe I'm just using the wrong path? Please let me know if that's the case :) )