implement visual bell - #1361
Open
luebking wants to merge 1 commit into
Open
Conversation
luebking
marked this pull request as ready for review
August 29, 2026 17:24
Contributor
Author
|
Withdrawing the draft to get some comments (not gonna add a config as long as the silence notification is pending or this one gets a clear go! ;))
|
Member
|
My answers are my opinions; they aren't meant to be a guide.
That being said, if it's completed, I think we should merge it only after the next release, in November. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1356
So here's a POC for the approach that does not require an (aligned) API update of qtermwidget.
Since the graphicseffect approach also means I get to do whatever I want, I want a bloodshot (like in FP shooters :))
The final implementation would probably use the red of the color scheme and also be configurable (if one prefers only an audible or no bell), for now this is RFC on the topic.