Initial POC for a colorscheme editor - #1219
Draft
luebking wants to merge 1 commit into
Draft
Conversation
There're several glitches, notably because QTermWidget currently does not allow to reload/refresh its colorschemes Imports and new schemes will not even show up when restarting the preferences dialog. The dialog should probably use the configured font and maybe even change the groupbox background. Nighttime handling isn't implemented at all QTerminalWidget does also not take transient schemes One could use a tmpfile to transmit a faded version, but that's not very exciting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're several glitches, notably because QTermWidget currently does not allow to reload/refresh its colorschemes Imports and new schemes will not even show up when restarting the preferences dialog.
The dialog should probably use the configured font and maybe even change the groupbox background.
Nighttime handling isn't implemented at all
QTerminalWidget does also not take transient schemes One could use a tmpfile to transmit a faded version, but that's not very exciting