Conversation
Split custom_profile.rb (12 classes) into lib/xmi/custom_profile/ with autoload hub. Split ea_root.rb (447 lines) into lib/xmi/ea_root/ with 5 concern modules (XmlParsing, CodeGeneration, ExtensionLifecycle, TemplateHelpers, NamespaceHandling). Replace EaRoot Object.class_eval string-based code generation with direct Class.new + const_set + attribute/xml API calls. The output_rb_file debugging utility is preserved by generating strings from live classes. Add test coverage for XmiIdentity, ParserPipeline, GML shared modules, Index, CustomProfile, and EaRoot extension loading (249 total examples, +63 from 186). 249 examples, 0 failures. Rubocop clean on 519 files.
ronaldtse
force-pushed
the
refactor/split-monoliths-replace-string-eval
branch
from
ee39229 to
73cf5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_profile.rb(12 classes) intolib/xmi/custom_profile/directory with autoload hubea_root.rb(447 lines) intolib/xmi/ea_root/with 5 concern modules (XmlParsing, CodeGeneration, ExtensionLifecycle, TemplateHelpers, NamespaceHandling)Object.class_evalstring-based code generation in EaRoot with directClass.new+const_set+ attribute/xml API callsChanges
output_rb_filepreserved by generating string from live classesprivate_constantto avoid pollutingEaRoot.constantsTest plan
bundle exec rubocop -A --auto-gen-configpasses