Conversation
ronaldtse
force-pushed
the
fix/same-document-node-creation-and-namespace-scopes
branch
2 times, most recently
from
9bd8816 to
72a7cdf
Compare
- Fix Oga doctype SYSTEM/PUBLIC identifier mapping (Oga stores SYSTEM identifier in public_id, not system_id) - Add Builder#doc alias for document accessor - Add doctype parsing specs for all adapters
ronaldtse
force-pushed
the
fix/same-document-node-creation-and-namespace-scopes
branch
from
72a7cdf to
54faa01
Compare
ronaldtse
deleted the
fix/same-document-node-creation-and-namespace-scopes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes based on issues discovered during lutaml-model migration to moxml.
1. Builder doc accessor
Moxml::Builder exposes document via attr_reader but consumers expected doc. Added doc alias.
2. Oga Doctype SYSTEM identifier fix
Oga native Doctype stores the SYSTEM identifier in public_id instead of system_id for SYSTEM doctypes. The adapter now maps correctly based on doctype type.
3. Nokogiri entity handling
Nokogiri raises FATAL errors on undefined HTML entities (nbsp, mdash, etc) in strict mode. Added marker-based preservation: entities are converted to name; before parsing and restored during serialization.
Test plan