Add ancestors, descendants, path, and line_number methods to Node#47
Draft
Add ancestors, descendants, path, and line_number methods to Node#47
Conversation
Co-authored-by: ronaldtse <11865+ronaldtse@users.noreply.github.com>
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Co-authored-by: ronaldtse <11865+ronaldtse@users.noreply.github.com>
Co-authored-by: ronaldtse <11865+ronaldtse@users.noreply.github.com>
…ing comments Co-authored-by: ronaldtse <11865+ronaldtse@users.noreply.github.com>
Co-authored-by: ronaldtse <11865+ronaldtse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add more node methods for ancestors, descendants, path, and line number
Add ancestors, descendants, path, and line_number methods to Node
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements four node navigation methods referenced in documentation but previously unimplemented.
Changes
Node class (
lib/moxml/node.rb)ancestors- Returns NodeSet of all ancestor nodes from parent to documentdescendants- Returns NodeSet of all descendant nodes (recursive children)path- Returns XPath expression locating the nodeline_number- Returns source line number (adapter-dependent)Adapter implementations (
lib/moxml/adapter/*.rb)pathandline/line_nummethodsline_numberreturnsnilUsage
Tests
Added comprehensive test coverage in
spec/moxml/node_spec.rbfor all four methods.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.