Feature/0.0.0.17#27
Open
DanielIxiguez wants to merge 9 commits intodevelopfrom
Open
Conversation
DanielIxiguez
requested review from
a team,
BalderramaJFP,
JuanGamezSW,
RICH-CD,
alxcodes,
helttonrl,
lupitalvarado and
rbarusta
JuanGamezSW
suggested changes
Jul 1, 2021
Contributor
JuanGamezSW
left a comment
JuanGamezSW
left a comment
There was a problem hiding this comment.
Además de los comentarios, hay UT fallando.
| public class Resend_Test | ||
| { | ||
| [Fact] | ||
| [Fact(Skip = "bug SMARTER-2687")] |
Contributor
There was a problem hiding this comment.
no veo razon para hacer el skip, el issue mencionado no tiene nada relacionado con el re-envio de email.
Author
There was a problem hiding this comment.
Como no puede deserializar la respuesta regresa un error, pero el xml si se envía.
Contributor
There was a problem hiding this comment.
Si es una corrección rápida porque no se incluye?
JuanGamezSW
suggested changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
skip fact Resend_Test, bug SMARTER-2687
Se agrega método para recuperar xml en timbrado CustomId