fix(electron): persist macOS zoom and window bounds across reopen#530
Open
passion729 wants to merge 2 commits intolukilabs:mainfrom
Open
fix(electron): persist macOS zoom and window bounds across reopen#530passion729 wants to merge 2 commits intolukilabs:mainfrom
passion729 wants to merge 2 commits intolukilabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes macOS window state persistence issues when reopening the app window without fully quitting.
This PR now covers:
Fixes #529
Changes
windowZoomFactor)webContentszoom change eventsWindowManager(workspace, bounds, focused, url)app.activate(Dock reopen with no windows), restore from last-closed/saved window state instead of default window sizebefore-quit, avoid saving an empty window list when all windows were already closed by reusing last-closed window stateTesting
Cmd +/Cmd -)Cmd + W/ traffic-light close), do not quit appbun run typecheck:sharedbun run typecheck:electron