Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any non-string values passed to
clsx/liteare intentionally ignored, thus passing arrays or objects to it is likely an error.Currently,
clsxandclsx/liteuse the same type declaration, resulting in these user errors not being identified by type checking.This pull request introduces a new type declaration for
clsx/lite. In comparison to the previous declaration, the follow argument types are still accectped:string | boolean | undefined | nulland the following types are not accepted anymore:
ClassArray | ClassDictionary | number | bigintThis should help catch user errors.