Handle multiple dropboxes#801
Open
jbz wants to merge 3 commits intolra:masterfrom
jbz:handle-multiple-dropboxes
Open
Handle multiple dropboxes#801jbz wants to merge 3 commits intolra:masterfrom jbz:handle-multiple-dropboxes
jbz wants to merge 3 commits intolra:masterfrom
jbz:handle-multiple-dropboxes
Conversation
added 3 commits
April 17, 2016 11:24
Switch to using info.json, falling back to host.db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user has a Personal and Business Dropbox, only one will be in hosts.db and it's not deterministic which. This PR mods utils.py to check info.json (the new account file) on create config - if there are more that one accounts listed, it notifies the user and asks them to pick one to get the mackup folder path from. If there is one account in info.json, it behaves as before; if info.json isn't available, it tries hosts.db as a fallback, and if neither, then errors.
Did this because syncing to a Dropbox once means making your files visible in version control on that organization (recover deleted) even if you'd prefer not to. Also means not having to go try to move the mackup folder once configured.
Possible Issues
I've seen issues with info.json not being updated by Dropbox when an account is unlinked, or re-linked. However, the code will still act sensibly given the information in it. I have a bug filed with Dropbox about info.json not updating.