Open
Conversation
Contributor
|
@lra Is there anything preventing the merge of this PR? It really could be handy for some softwares. |
Owner
|
It's a big change with a lot of edge cases to test. |
|
Is this dead, or has globbing been enabled elsewhere? |
Contributor
|
@EvilJimJafar no one has taken ownership of this yet, it's a pretty significant feature that needs solid testing before it would be published. Let us know if you want to implement this feature. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some configuration files contain application version in their paths. So you have to explicitly list all the versions. For example: https://github.com/lra/mackup/blob/master/mackup/applications/intellijidea.cfg
I have add the support of globing to solve this problem. You have to explicitly enable this feature to use it. So there are no issues with backward compatibility.
Related issues:
#1440
#1436