Change finding logic for Dropxbox folder paths#1106
Open
Xeite wants to merge 1 commit intolra:masterfrom
Open
Conversation
Change Dropbox metadata file to info.json because newer Dropbox find Dropbox folder paths using info.json instead of host.db. Also, there are chances to have more than one Dropbox accounts, so support to choose right one.
Contributor
|
Please add changes and your name to the WIP section in CHANGELOG.md Also, do you know if any old versions still use host.db? Seeing how the issue is from 2014 I assume we don't have to worry about this but if older versions haven't been deprecated we might still need a fall-back to host.db. I couldn't find anything but it's best to be on the safe side. |
Author
|
Thanks for review. Then do I have to add fallback logic for host.db? |
Contributor
|
Sorry for the late reply: Please do. |
MadeOfMagicAndWires
suggested changes
Mar 9, 2018
Contributor
MadeOfMagicAndWires
left a comment
MadeOfMagicAndWires
left a comment
There was a problem hiding this comment.
See above comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Dropbox metadata file to info.json because newer Dropbox find
Dropbox folder paths using info.json instead of host.db. Also, there
are chances to have more than one Dropbox accounts, so support to
choose right one.
Resolve #301