Open
Conversation
|
It also would permit us to upgrade Bootstrap too. And make the report itself accessible. |
lpelypenko
reviewed
Oct 25, 2024
|
|
||
| const reportFileName = 'custom_index.html'; | ||
| const templatePath = path.join(__dirname, 'pageTemplateOnlyBody.html'); | ||
| const outputDir = 'docs'; |
Owner
There was a problem hiding this comment.
It would be better to save the results of test files into the artifacts folder instead of docs because docs is meant only for index.html that is generated by tests but used as source of https://lpelypenko.github.io/axe-html-reporter/. HTML report is saved artifacts by default.
It is easy to do just by removing const outputDir = 'docs'; line and not passing it in createHtmlReport like this:
const templatePath = path.join(__dirname, 'pageTemplateOnlyBody.html');
createHtmlReport({
results: rawAxeResults,
options: { projectKey: 'DEQUE',
customSummary, reportFileName, templatePath },
});
expect(
fs.readFileSync(getPathToCreatedReport(reportFileName), {
encoding: 'utf8',
})
).toMatchSnapshot();
Thank you!
Owner
|
Any news ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to use a custom html template, that is useful if for example you need to use other css framework than bootstrap, or you want the output to be embedded to another page.