Added an option to support displaying screenshot of the element#17
Open
zhenyanghua wants to merge 3 commits intolpelypenko:mainfrom
Open
Added an option to support displaying screenshot of the element#17zhenyanghua wants to merge 3 commits intolpelypenko:mainfrom
zhenyanghua wants to merge 3 commits intolpelypenko:mainfrom
Conversation
Owner
|
Hi @zhenyanghua, I am so sorry for the delay, I will try to look on how this feature works for me locally this week and release by the weekends. |
Owner
|
Hi @zhenyanghua, |
|
I am also interested in this functionality. We need to pass reports back to a Design Team, and without screenshots it's more tricky. |
|
This for sure would be a great to have |
|
that would be awesome, please look further into it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liliia (@lpelypenko), thanks for this useful project, it allows us to generate customized report with the foundation you have built.
One thing we love to have is the ability to display a screenshot of an element that has the violation to the specified rules. Because different clients may use different browser driver, with an option to pass in a custom function that returns the processed screenshots will be ideal for broader adaption.
In our case, with this proposed option, we are able to do this:
Which allows us to display an image like this: