Merged
Conversation
6d268fa to
1b56db2
Compare
ab244aa to
322113a
Compare
Contributor
Author
|
Switched back to draft for now - this should use the static versions of GMP and MPFR instead. |
322113a to
483e723
Compare
483e723 to
7e4cfe4
Compare
cae1bc2 to
5e868b1
Compare
Upstream binutils now supports the ratified 1.0.0 bitmanip extensions, so rather than maintaining patches to add the unratified extensions back in, a fork of binutils was created which we now use, and should allow for easier updates to future versions. The glob and ELF BFD patches are no longer required for this version of binutils to build correctly so they are removed. Since the last version of binutils used, the GMP and MPFR libraries have become required for building GDB. However, the configure step will always prefer the shared library rather than the static one when building, so we have to build our own static-only libraries of these to link. MPFR is clone-able from the official repository, however GMP does not appreciate excessive cloning, so we use a release archive instead for that. The updated binutils contain a change for generating verilog memory (vmem) files that is useful for OpenTitan. See also: https://github.com/lowRISC/binutils Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
5e868b1 to
0ce4e33
Compare
jwnrt
approved these changes
Nov 25, 2025
Closed
luismarques
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As upstream now supports the Bitmanip 1.0.0 spec, the unratified extension support was re-implemented in a fork of Binutils. This should make it easier and less error-prone to update to newer versions, instead of applying a patch.
The BFD and libc patches are also no longer needed in this version of Binutils, so that leaves no more patching.
Since the last version of Binutils we used, GMP and MPFR have become required dependencies of GDB. However, the configure script prefers to dynamically link shared libraries if they are available, and fallback to static ones if they are not present, so we opt to build both libraries statically as part of the build script.