chore: improvements for sweepIncomingBuffer#2668
Closed
danisharora099 wants to merge 1 commit intomasterfrom
Closed
chore: improvements for sweepIncomingBuffer#2668danisharora099 wants to merge 1 commit intomasterfrom
sweepIncomingBuffer#2668danisharora099 wants to merge 1 commit intomasterfrom
Conversation
- O(n x h x m) to O(n x m)
size-limit report 📦
|
fryorcraken
reviewed
Nov 12, 2025
| private possibleAcks: Map<MessageId, number>; | ||
| private incomingBuffer: Array<ContentMessage | SyncMessage>; | ||
| private readonly localHistory: ILocalHistory; | ||
| private localHistoryIndex: Set<MessageId>; |
Collaborator
There was a problem hiding this comment.
As discussed on Discord, move this to behind ILocalHistory interface, as an implement detail/optimisation.
ILocalHistory being an Array with a subset of function was an easy way to start setting a boundary.
You can move away from that and start expecting ILocalHistory to implement a findMissingDependencies function, that does what you want to do in an efficient manner.
Collaborator
Author
There was a problem hiding this comment.
agreed - localHistory/ILocalHistory abstracts away the messageIndexand uses it via findMissingDependencies: #2745
Collaborator
Author
|
superseded by #2745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Description
Solution
Notes
Checklist