Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Cylinder chandrasekar roe CI
Added important note regarding the GPU version limitations.
Added information about GPU version limitations and Riemann solvers.
Activiate first GPU MU test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test case for a cylinder simulation using Chandrasekar averaging with the Roe Riemann solver, along with several bug fixes and GPU-related updates. The changes support the GPU version of HORSES3D by fixing array slicing issues, correcting variable declarations, and adjusting CI workflows.
Key changes:
- New Navier-Stokes test case for cylinder simulation with Chandrasekar averaging and Roe Riemann solver
- Bug fixes in boundary conditions and MPI communication (NCOMP → NCONS, explicit array slicing)
- Updates to CI workflows to disable unsupported test cases in GPU version
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Solver/test/NavierStokes/CylinderChandrasekarRoe/SETUP/ProblemFile.f90 | New problem file for CylinderChandrasekarRoe test case |
| Solver/test/NavierStokes/CylinderChandrasekarRoe/CylinderChandrasekarRoe.control | Control file for the new test case with Roe solver and Chandrasekar averaging |
| Solver/test/NavierStokes/Cylinder/Cylinder.control | Updated to use Roe solver with CFL-based time stepping and AOA phi = 90.0 |
| Solver/src/libs/physics/common/bcs/NoSlipWallBC.f90 | Fixed variable declaration from Q(NCOMP) to Q(NCONS) |
| Solver/src/libs/physics/common/bcs/FreeSlipWallBC.f90 | Fixed variable declaration from Q(NCOMP) to Q(NCONS) |
| Solver/src/libs/mesh/HexMesh.f90 | Fixed array slicing in MPI communication to use explicit ranges |
| Solver/src/MultiphaseSolver/SpatialDiscretization.f90 | Fixed duplicate MPI call and corrected function call |
| Solver/configure | Added CylinderChandrasekarRoe to test cases list |
| README.md | Added documentation about GPU version limitations |
| .github/workflows/CI_serial_MU.yml | New workflow file for serial multiphase tests |
| .github/workflows/CI_parallel_NS.yml | Updated to disable GPU-incompatible Euler tests and add new cylinder test |
| .github/workflows/CI_parallel_MU.yml | Updated to disable GPU-incompatible multiphase tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| viscous discretization = IP | ||
|
|
||
| The next Riemman solvers are 4-5 times slower than Roe Riemman solver: |
There was a problem hiding this comment.
Corrected spelling of 'Riemman' to 'Riemann' (appears twice in this line).
Suggested change
| The next Riemman solvers are 4-5 times slower than Roe Riemman solver: | |
| The next Riemann solvers are 4-5 times slower than Roe Riemann solver: |
Owner
There was a problem hiding this comment.
@copilot, this implementation has a problem with the actuator line and an error is generated after 1000 iterations. Can you check?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First see copilot